Maor Lipchuk has submitted this change and it was merged. Change subject: core: Introduce StorageTypeSharedComparator. ...................................................................... core: Introduce StorageTypeSharedComparator. When selecting a domain to place memory volumes, there are currently three comparators that choose the target domain: * Number of the VM's disks in the domain * File storage over block storage * Free space - prefer domains with more free space To improve resiliency, we should prefer shared domains over local domain as the second criteria. Change-Id: I27fd13f2cc97874440671a24d3dc17af6e2d4b66 Bug-Url: https://bugzilla.redhat.com/1353137 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandler.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageTypeSharedComparator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageTypeSharedComparatorTest.java 3 files changed, 54 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27fd13f2cc97874440671a24d3dc17af6e2d4b66 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;