Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: CidrValidation refactor ...................................................................... webadmin: CidrValidation refactor Refactoring CidrValidation and its corresponding test. The refacor will make the test atomic. Will later be refactor again to support cidrValidator injection. Change-Id: I062320b351df6933a45b730ac4ce3b54a7881706 Bug-Url: https://bugzilla.redhat.com/1269481 Signed-off-by: Eliraz Levi <elevi(a)redhat.com&gt; --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CidrValidation.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/CidrValidationTest.java 2 files changed, 79 insertions(+), 86 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49922 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I062320b351df6933a45b730ac4ce3b54a7881706 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com&gt; Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com&gt; Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;