Daniel Erez has submitted this change and it was merged. Change subject: ui: use equals comparison for alignment attribute ...................................................................... ui: use equals comparison for alignment attribute Using string equals comparison instead of by reference. Note: StringHelper is deprecated - using stringsEqual just for keeping the current convention and ease later cleanup of the class. Change-Id: I5769aa78f4bc740c7fad7ca22af996c9a221ba76 Signed-off-by: Federico Simoncelli <fsimonce@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskGeneralModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5769aa78f4bc740c7fad7ca22af996c9a221ba76 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Liron Ar <laravot@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server