Arik Hadas has submitted this change and it was merged. Change subject: webadmin: remove volume format from disk model ...................................................................... webadmin: remove volume format from disk model Remove volume format from AbstractDiskModel. Currently the user can't set it explicitly and it is set according to the volume type. So there is no reason to store it in the model, but to compute it when needed according to the selected volume type. Change-Id: Id4a538d8adb2622caf4679a37318ada5933d8146 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java 3 files changed, 1 insertion(+), 17 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4a538d8adb2622caf4679a37318ada5933d8146 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server