Tal Nisan has submitted this change and it was merged. Change subject: core :fix PowerSavingWeight score calculation ...................................................................... core :fix PowerSavingWeight score calculation EvenDistributionWeightPolicy unit calculated a weight score that was comprised from CPU usage and memory consumption. This calculation was wrong (which Power saving weight module relied on) there was a need to separate the weight policy units to 2 units : EvenDistributionCPUWeightPolicy and EvenDistributionMemoryWeightPolicy which produced 2 new power saving units: PowerSavingMemoryWeightPolicyUnit and PowerSavingMemoryCPUPolicyUnit instead of PowerSavingWeightPolicyUnit. CPU usage is calculated as before (power saving unit takes the opposite score) Memory score is calculated by the range of 1 to the maximum available memory of a host in the cluster and normalized to the score range. NonWeightPolicy unit was removed and will replaced with memory and CPU even distribution policies under the default 'None' scheduling policy Change-Id: I4ed2fa107b4c1139a4a4f9c07894472280acbf6b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1349345 Signed-off-by: Yanir Quinn <yquinn@redhat.com> Signed-off-by: yquinn <yquinn@redhat.com> (cherry picked from commit 6037d1886788e42d9a923fe670b84da907da5e16) Signed-off-by: yquinn <yquinn@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionCPUWeightPolicyUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionMemoryWeightPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnit.java C backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingCPUWeightPolicyUnit.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingMemoryWeightPolicyUnit.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingWeightPolicyUnit.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnitTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingWeightPolicyUnitTest.java A packaging/dbscripts/upgrade/03_06_2160_add_memory_cpu_policy_units.sql 10 files changed, 330 insertions(+), 106 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/59787 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ed2fa107b4c1139a4a4f9c07894472280acbf6b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yanir Quinn <yquinn@redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar@redhat.com> Gerrit-Reviewer: Martin Sivák <msivak@redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey@redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>