Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support recursive remove of cinder volumes. ...................................................................... core: Support recursive remove of cinder volumes. Implementing a recursive way to remove Cinder volumes. As part of this implementation the behviour should be as follow: When trying to remove a Cinder disk we aggragate all the volumes of the Cinder disk, snapshots and Cinder volumes (commited snapshots). Then we execute them one at a time, if there is a failure in the middle we change the disk status to illegal and fail the command. Once an illegal Cinder disk is being removed we only remove the Cinder disk and its volumes from the DB, without removing it from the Cinder provider. Change-Id: Icc5c19c0fa06f2fb40423072e609b3c0ca7f28f3 Bug-Url: https://bugzilla.redhat.com/1278126 Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RestoreFromCinderSnapshotCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveCinderDiskParameters.java 5 files changed, 293 insertions(+), 200 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/46042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc5c19c0fa06f2fb40423072e609b3c0ca7f28f3 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: automation@ovirt.org