Tal Nisan has submitted this change and it was merged. Change subject: core: Fix disk profile matching by storage domain ...................................................................... core: Fix disk profile matching by storage domain Disk profile matching by storage domain was done incorrectly Taking under account only the storage domain default disk profile. Matching a disk profile by storage domain is now done against all disk profiles of that storage domain. In addition added correct syntax in errors messages. Change-Id: I074427d394da5610e1327b20a15cc76b1e5f6f43 Bug-Url: https://bugzilla.redhat.com/1361838 Signed-off-by: Yanir Quinn <yquinn@redhat.com> (cherry picked from commit e20ff86) Signed-off-by: Yanir Quinn <yquinn@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelperTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 5 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/63535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I074427d394da5610e1327b20a15cc76b1e5f6f43 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Yanir Quinn <yquinn@redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar@redhat.com> Gerrit-Reviewer: Martin Sivák <msivak@redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>