Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetStorageServerConnectionsQuery ...................................................................... core: Remove GetStorageServerConnectionsQuery GetStorageServerConnectionsQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetStorageServerConnectionsQuery class 2. The GetStorageServerConnections constant representing it in VdcQueryType 3. The getAll() method in StorageServerConnectionsDAO (which was only used by the query), its implementation, and its test. 4. The GetAllFromstoage_server_connections stored procedure that was only used by the said DAO function. Note that the test for StorageServerConnectionsDao.get(Guid) is slightly redone so it no longer depends on getAll()'s implementation. Change-Id: I352f819dd3a7b272ccf1b39cfcf76cca62a8ee10 Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M backend/manager/dbscripts/storages_san_sp.sql D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageServerConnectionsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDAOTest.java 6 files changed, 5 insertions(+), 62 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I352f819dd3a7b272ccf1b39cfcf76cca62a8ee10 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com&gt; Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com&gt; Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com&gt;