Daniel Erez has submitted this change and it was merged. Change subject: core: fix update VmDevices when VM is down ...................................................................... core: fix update VmDevices when VM is down Updating VmDevices when the VM isn't running, mistakenly leads to next run snapshot creation. Therefore, modified 'VmHandler -> isUpdateValidForVmDevices': the function should check whether updating is valid according to the status of the VM; hence, VmStatus should be specified (so it could be validated properly on 'getVmDevicesFieldsToUpdateOnNextRun -> isUpdateValidForVmDevice'). Change-Id: Ia7a8f2a4c3f41b18a7c02ca162b01ee352e49bcf Signed-off-by: Daniel Erez <derez@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmUpdatesOnNextRunExistsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 4 files changed, 8 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7a8f2a4c3f41b18a7c02ca162b01ee352e49bcf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server