Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: v2v-fix message and load button enabling ...................................................................... webadmin: v2v-fix message and load button enabling While opening the "import Virtual Machine(s)" dialog, the following error message always appears on start: "Not available when no Export Domain is active", although an active export domain does exist and active. And also "Load" button is enabled while should be disabled. The reason is that checking export Domain existence for the "Export Domain" Source is done on VmListModel constructor on initializing while querying for getting the export Domain is done later on while query callback returns from backend. So while opening the dialog, exportDomain is always null. The same relevant for enabling the "Load" button. Fixing that bug requires moving the error message and button enabling checks to later on. Immediate after reading the export domain from DB. Current behaviour is as follows: 1. While opening the dialog - error message and button disabling appears only if no export doamin really exists for that DC. 2. Changing the Source from other source back to be "Export Domain" - no actul checking is done for export domain existence. The previous status is kept and displayed. 3. Selecting other Data Center for the "export Domain" source - actual checking is done by querying the DB and in case no export Domain exists then an err msg in dislayed and "load" button is disabled. Furtheremore, this fix cleans VMs list while selecting other Data Center Change-Id: I2e89d26ce8363c111f5df91bc4a214011270c920 Bug-Url: https://bugzilla.redhat.com/1340025 Signed-off-by: Sharon Gratch <sgratch@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/ImportVmsPopupPresenterWidget.java 2 files changed, 32 insertions(+), 24 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved Sharon Gratch: Verified Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/61607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e89d26ce8363c111f5df91bc4a214011270c920 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sharon Gratch <sgratch@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com> Gerrit-Reviewer: Sharon Gratch <sgratch@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>