Alona Kaplan has submitted this change and it was merged. Change subject: engine: Re-construct SetupNetworks steps ...................................................................... engine: Re-construct SetupNetworks steps The deprecated SetupNetworks command is being updated to use HostSetupNetworks introduced sequence of actions: 1. DRY - reuse the HostSetupNetworkPoller for polling connectivity to the host while executing the setupnetworks on vdsm. 2. Replaced 'all-in-one' vdsbroker CollectVdsNetworkDate with few steps that separates the concern of persisting the network changes from the network data collected process. SetupNetworks requires specific behavior to preserves nics additional attributes (i.e. labels), hence specifying that logic explicitly as part of this command clarify the action. Change-Id: I79fe45714f0f9ed4348f7c68c2b38cf1ace57fa6 Signed-off-by: Moti Asayag <masayag@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java 1 file changed, 34 insertions(+), 37 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Objections: Jenkins CI: Fails -- To view, visit https://gerrit.ovirt.org/35376 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79fe45714f0f9ed4348f7c68c2b38cf1ace57fa6 Gerrit-PatchSet: 38 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: automation@ovirt.org