Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Inline Linq#filterProvidersByProvidedType ...................................................................... webadmin: Inline Linq#filterProvidersByProvidedType Linq#filterProvidersByProvidedType is only used in one place, AsyncDataProvider, and as such shouldn't belong in a general-purpose class like Linq. Since Java 8's streams provide an elegant, single-statement, way of achieving the same functionality, this patch removes that method and inlines its functionality directly where its needed. As an added bonus, this patch consolidates the filtering and the sorting of the resulting list, generating a slight performance improvement. Change-Id: I5e7e2bb37529c1d5327ec962e926473acbd2ff4d Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 2 files changed, 5 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e7e2bb37529c1d5327ec962e926473acbd2ff4d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;