Change in gerrit-admin[master]: fix change-merged.set_MODIFIED hook

Eyal Edri has submitted this change and it was merged. Change subject: fix change-merged.set_MODIFIED hook ...................................................................... fix change-merged.set_MODIFIED hook The current state of the hook is that it moves bugs from POST ==> MODIFIED with wrong logic. Example 1: bug target milestone: ovirt-4.0.2 change branch: master After merge the bug will be moved automatically from POST ==> MODIFIED although it was merged to master to perform a backport Example 2: bug target milestone: ovirt-4.0.2 change branch: ovirt-engine-4.0 After merge the bug will be moved automatically from POST ==> MODIFIED although the branch ovirt-engine-4.0.2 exist The new logic is as follows: 1. changes on master branch with any bug tm_suffix. ==> bug will be skipped (stay on POST) 2. changes that their branch_suffix match bug tm_suffix (i.e tm_suffix=4.0.2 and branch_suffix=4.0.2) ==> bug will be moved (POST ==> MODIFIED) 3. changes that their branch_suffix match bug tm_suffix (X.Y) and branch (ovirt-engine-4.0.4) isn't exist (i.e tm_suffix=4.0.4 and branch_suffix=4.0) ==> bug will be moved (POST ==> MODIFIED) else ==> bug will be skipped (stay on POST) Change-Id: I248346f923e5ec0002526cc7e4e94733c9be4524 Signed-off-by: Shlomi Ben-David <sbendavi@redhat.com> --- M hooks/custom_hooks/change-merged.set_MODIFIED 1 file changed, 55 insertions(+), 57 deletions(-) Approvals: Shlomo Ben David: Verified Eyal Edri: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62783 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I248346f923e5ec0002526cc7e4e94733c9be4524 Gerrit-PatchSet: 8 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi@redhat.com> Gerrit-Reviewer: Eyal Edri <eedri@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
eedri@redhat.com