Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove DbFacade#isStoragePoolMasterUp(Guid) ...................................................................... core: Remove DbFacade#isStoragePoolMasterUp(Guid) The isStoragePoolMasterUp(Guid) method has no place in DbFacade, that's supposed to be a general access point that provides the various DAOs. Moreover, its implementation is awful, retrieving all of the pool's domains from the database and iterating them one by one to find the master domain in memory, instead of applying that filtering the query itself. This patch removes this useless method and its tests, and replaces it with a method in IrsProxyData (the only place that used this call), which is implemented properly, by retrieving only the correct domains from the database, offering a slight performance benefit by the way. Change-Id: I27b0ab4ae9b253ece29be97e9d9ae86ba9aefcb0 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDaoTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 3 files changed, 7 insertions(+), 46 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27b0ab4ae9b253ece29be97e9d9ae86ba9aefcb0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Ala Hino <ahino@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>