Mike Kolesnik has submitted this change and it was merged. Change subject: core: Validate vm nic name has no special characters ...................................................................... core: Validate vm nic name has no special characters The patch validates the vm nic name is consisted of a-zA-Z0-9-_. only. This is verified on the UI but should be enforced when adding nics via the API. Change-Id: I596f546473b1e4c8832aa56dd56320df514977ae Bug-Url: https://bugzilla.redhat.com/973971 Signed-off-by: Moti Asayag <masayag@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNic.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidNameWithDot.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 43 insertions(+), 6 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/18487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I596f546473b1e4c8832aa56dd56320df514977ae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server