Oved Ourfali has submitted this change and it was merged.
Change subject: core: Fix Coverity issue in AuditLogableBaseTest
......................................................................
core: Fix Coverity issue in AuditLogableBaseTest
Fixes false Coverity issue in getVdsWithVdsId() test, when null was
passed to setVds() and valid UUID was passed to setVdsId(). Because
getVds() checks for vdsId when vds is null, the method returned valid
VDS object using vdsId (but Coverity wasn't able to figure it out).
Change-Id: Id1d6b6ab0abc048adcdacbecb465802c0626b34d
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/37406
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1d6b6ab0abc048adcdacbecb465802c0626b34d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server