Eli Mesika has submitted this change and it was merged. Change subject: core:pre upgrade scripts will not run ...(#842119) ...................................................................... core:pre upgrade scripts will not run ...(#842119) pre upgrade scripts will not run correctly upon 3.0 DB restore https://bugzilla.redhat.com/show_bug.cgi?id=842119 Restore a 3.0 database and running the 3.1 upgrade scripts on it is not working. This patch fixes this problem by : 1) force pre-upgrade scripts to run if any upgrade file is about to run , this will be done even if no change was detected in views, sp & upgrade files as it may occur when the database is restored. 2) make pre-upgrade and post upgrade scripts ordered since the configuration settings and some fixes in the custom sql file must run first. This is done by prefixing the script name with a 4 digit number. (0000 00010 00020 etc.) Change-Id: Ie23fba63cee81c5a5b3f1ad4076d627a06614fc0 Signed-off-by: Eli Mesika <emesika@redhat.com> (cherry picked from commit 5845c732560dc325132661e1d1260de0a096c6b7) --- M backend/manager/dbscripts/dbfunctions.sh R backend/manager/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql R backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql R backend/manager/dbscripts/upgrade/pre_upgrade/0010_custom.sql R backend/manager/dbscripts/upgrade/pre_upgrade/0020_add_comment_col_to_schema_version.sql 5 files changed, 9 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Ofer Schreiber: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie23fba63cee81c5a5b3f1ad4076d627a06614fc0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.1 Gerrit-Owner: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>