Omer Frenkel has submitted this change and it was merged. Change subject: engine: Common method to update brick server name ...................................................................... engine: Common method to update brick server name Moved the logic of updating server names in bricks from CreateGlusterVolumeCommand to the base class GlusterCommandBase, and modified CreateGlusterVolumeCommand and ReplaceGlusterVolumeBrickCommand to make use of the same. Change-Id: Id532706d65af4a20f8651202b1b50a1d7572ab46 Signed-off-by: Shireesh Anjal <sanjal@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommandTest.java 4 files changed, 67 insertions(+), 12 deletions(-) Approvals: Shireesh Anjal: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id532706d65af4a20f8651202b1b50a1d7572ab46 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal@redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal@redhat.com>