From Allon Mureinik <amureini@redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80310 ) Change subject: core: Inline IscsiBondDaoTest members ...................................................................... core: Inline IscsiBondDaoTest members At best, IscsiBondDaoTest's members just hold constant values from FixturesTool, which do nothing but add visual spam to the code. At worst, these members are updated inside test cases, which may cause hard-to-find bugs which only reproduce with certain test runners. This patch inlines those members so the constants from FixturesTool are used directly where possible, and local variables are used when other values are needed. Change-Id: Id27820e873bcc17886112beaae0a5b9b7ae88a29 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/IscsiBondDaoTest.java 1 file changed, 25 insertions(+), 33 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80310 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id27820e873bcc17886112beaae0a5b9b7ae88a29 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>