Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Improve display of failed expectations
......................................................................
restapi: Improve display of failed expectations
Currently the display of failed query and action expectations created
with the "eqQueryParams" and "eqActionParams" methods consist on the
names of the fields, without the values, for example:
Expectation failure on verify:
runQuery(
GetVmByVmId,
eqQueryParams(
, field: Id
, field: SessionId
)
): expected: 1, actual: 0
This patch changes the implementation of these methods so that they will
display the names of the fields and the values, for example:
Expectation failure on verify:
runQuery(
GetVmByVmId,
eqQueryParams(
Id=11111111-1111-1111-1111-111111111111,
SessionId=5bb9a592-b4f2-46b5-a375-1ce5a89fd9e2
)
): expected: 1, actual: 0
This helps when developing and debugging tests.
Change-Id: I234e317a9fc7bcb0f16d7eb88ead0fb21cd54733
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/test/util/TestHelper.java
1 file changed, 14 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/42830
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I234e317a9fc7bcb0f16d7eb88ead0fb21cd54733
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org