Allon Mureinik has submitted this change and it was merged. Change subject: core: TrybackToAllSnapshots vmDown validation ...................................................................... core: TrybackToAllSnapshots vmDown validation Added an explicit test for VM.isDown in TrybackToAllSnapshotsOfVmCommand.canDoAction() instead of using ImagesHandler.PerformImagesChecks to do it. This patch contains the aforementioned code change, a test for it, and a minor refactor required to facilitate the test. Note: This patch is part of a series intended to remove the VM status check from ImagesHandler. Change-Id: I5f8fa014e73e6f10693edd1e4ccff4656d50053b Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommandTest.java 2 files changed, 76 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f8fa014e73e6f10693edd1e4ccff4656d50053b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com>