Oved Ourfali has submitted this change and it was merged. Change subject: core: refactor failure to run vm flow - part 5 ...................................................................... core: refactor failure to run vm flow - part 5 This patch is a preliminary step before removing MigrateVmCommand#reportCompleted: - Move the call to freeLock to RunVmCommandBase#reportCompleted - Extract the code that actually ends the command's monitoring job/step to separate method. RunVmCommand & RunVmOnceCommand used to override RunVmCommandBase#reportCompleted just to change the way the job/step is ended, so they are now override the new method instead. Change-Id: Ib02c6a37333785845e6e8246b1a8f4c326e9049d Bug-Url: https://bugzilla.redhat.com/1049321 Signed-off-by: Arik Hadas <ahadas(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 4 files changed, 29 insertions(+), 23 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib02c6a37333785845e6e8246b1a8f4c326e9049d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com&gt; Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server