Omer Frenkel has submitted this change and it was merged. Change subject: dal: Refactor VmStatic and VmTemplate Daos ...................................................................... dal: Refactor VmStatic and VmTemplate Daos Extracted common fields from parameter sources of VmStatic and VmTemplate to new VmBaseDaoDbFacade. This new class also inheriths DefaultGenericDaoDbFacade to eliminate trivial implementations of get, update and delete in both DaoDbImpls. Change-Id: Ia8c02c11ededf4dfba67e5cc8598ae90155d7eb5 Signed-off-by: Martin Betak <mbetak(a)redhat.com&gt; --- D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/AbstractVmRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDAODbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDaoDbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java 5 files changed, 160 insertions(+), 211 deletions(-) Approvals: Martin Betak: Verified Roy Golan: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8c02c11ededf4dfba67e5cc8598ae90155d7eb5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com&gt; Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com&gt; Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com&gt; Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt; Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server