Tal Nisan has submitted this change and it was merged. Change subject: core: domain might remain locked on deactivation ...................................................................... core: domain might remain locked on deactivation When passing the compensation context to the child command the 'recorded' changes aren't reverted becasue when attempting to load the compensation data the load is by the command id which is different between the parent command and the child command. When no tasks are created when deactivating domain and the actual deactivation fails, the domain may remained locked because of the above reason in same usecases (if more updates using the compensation are done in the child command) Change-Id: I4a1bea6522ceb8c83be9466ed50748559745c3c8 Bug-Url: https://bugzilla.redhat.com/1185050 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/37233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a1bea6522ceb8c83be9466ed50748559745c3c8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server