Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Don't accept non-digit characters ...................................................................... webadmin: Don't accept non-digit characters Using IntegerEntityModelTextBoxEditor turned out to be the wrong choice, as it "swallows" non-integer input and simply translates it to a null Integer. For the validation to work properly, changed HostNetworkQosWidget to use StringEntityModelTextBoxEditor instead. Change-Id: I4ed3e4dd9aa1d464cab85e776396a5783ac91fcb Bug-Url: https://bugzilla.redhat.com/1181431 Signed-off-by: Lior Vernia <lvernia@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/HostNetworkQosParametersModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/HostNetworkQosWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/HostNetworkQosWidget.ui.xml 4 files changed, 44 insertions(+), 19 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit https://gerrit.ovirt.org/37430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ed3e4dd9aa1d464cab85e776396a5783ac91fcb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server