Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveDisk preview validation ...................................................................... core: RemoveDisk preview validation In RemoveDisk, moved the validation that the VM is not in preview from ImagesHandler to SnapshotValidator, which is a more logical place for it. This patch does not only clean up the code, it also solves a subtle bug in RemoveDisk's flow. Before this patch, the VM's preview status was checked only for plugged image disks. However, since removing a disk needs to update all of the VM's OVFs and remove it from them, it would have performed incorrectly if used on a VM during preview mode. Note: This patch is part of a series of patches aimed at removing the preview validation from ImagesHandler altogether. Change-Id: Iefbea2785b3637ea5df3953d6e8f1a24765742a0 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java 1 file changed, 14 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefbea2785b3637ea5df3953d6e8f1a24765742a0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com>