Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Aggregate errors by default in runMultipleActions() ...................................................................... webadmin: Aggregate errors by default in runMultipleActions() Changed the default calls to aggregate errors. Although this potentially affects several existing invocations, most of them provide a failure callback of their own and so render this argument irrelevant. The ones that are affected are SanStorageModelBase.connectTargets() and NewDiskModel.onAttachDisks(), where it seemed to me that the desireable behavior would indeed be to aggregate multiple errors if they are returned. Also corrected the Javadoc for some overloads in Frontend. Change-Id: I423a737888a3b3ec6bb492d8eaf825d9cce9872c Signed-off-by: Lior Vernia <lvernia@redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java 2 files changed, 12 insertions(+), 11 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/28216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I423a737888a3b3ec6bb492d8eaf825d9cce9872c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server