Arik Hadas has submitted this change and it was merged. Change subject: core: Simplify VideoDeviceSettings ...................................................................... core: Simplify VideoDeviceSettings Simplified VideoDeviceSettings, avoiding instantiation of inner classes and their inheritance from the common interface. Simple calls of static methods give exactly the same result. The inner classes were left untouched to scope interrelated methods and constants together. Change-Id: I725f3de52c490f37d6a13fe3e2bee76bca19cc83 Signed-off-by: Shmuel Melamud <smelamud@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VideoDeviceSettings.java 1 file changed, 20 insertions(+), 36 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57512 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I725f3de52c490f37d6a13fe3e2bee76bca19cc83 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>