Tal Nisan has submitted this change and it was merged. Change subject: core: relocate all storage connections related classes ...................................................................... core: relocate all storage connections related classes This patch is a part of a series of patches aimed to organize the org/ovirt/engine/core/bll/storage package. Specifically, it relocates all the storage connections related classes to org/ovirt/engine/core/bll/storage/connection and org/ovirt/engine/core/bll/storage/connection/iscsibond. Change-Id: Ia7ab4077fcb8efa6b6bedc590a690bdb1f615ef8 Signed-off-by: Idan Shaby <ishaby(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/CinderProviderValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/LibvirtSecretCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackVolumeProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConntectVDSToPoolAndDomains.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/AddStorageServerConnectionCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/AddStorageServerConnectionExtensionCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/AttachStorageConnectionToStorageDomainCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/BaseFsStorageHelper.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/CINDERStorageHelper.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ConnectDomainToStorageCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ConnectStorageToVdsCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/DetachStorageConnectionFromStorageDomainCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/DisconnectStorageServerConnectionCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/DiscoverSendTargetsQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/FCPStorageHelper.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GLUSTERFSStorageHelper.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetAllStorageServerConnectionsQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetConnectableStorageServerConnectionsByStoragePoolIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetConnectionsByDataCenterAndStorageTypeQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetStorageServerConnectionByIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetStorageServerConnectionByIscsiBondIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetStorageServerConnectionExtensionByIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetStorageServerConnectionExtensionsByHostIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetStorageServerConnectionsForDomainQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ISCSIStorageHelper.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/IStorageHelper.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/LOCALFSStorageHelper.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/NFSStorageHelper.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/POSIXFSStorageHelper.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/RemoveStorageServerConnectionCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/RemoveStorageServerConnectionExtensionCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageHelperBase.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageHelperDirector.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageServerConnectionCommandBase.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageServerConnectionExtensionCommandBase.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionExtensionCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/AddIscsiBondCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/BaseIscsiBondCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/EditIscsiBondCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/GetIscsiBondByIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/GetIscsiBondsByStoragePoolIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/RemoveIscsiBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DetachStorageDomainFromPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ForceRemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsWithAttachedStoragePoolGuidQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageConnectionValidator.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/AddStorageServerConnectionCommandTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/AttachStorageServerConnectionToStorageDomainCommandTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/ConnectStorageToVdsCommandTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/DetachStorageConnectionFromStorageDomainCommandTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/RemoveStorageServerConnectionCommandTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/StorageHelperBaseTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/StorageServerConnectionTestCommon.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommandTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionExtensionCommandTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/GetIscsiBondByIdQueryTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/GetIscsiBondsByStoragePoolIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/RemoveStorageDomainCommandTest.java 87 files changed, 101 insertions(+), 82 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/49202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7ab4077fcb8efa6b6bedc590a690bdb1f615ef8 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt; Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;