From Arik Hadas <ahadas@redhat.com>:

Arik Hadas has submitted this change and it was merged. Change subject: core: Refactoring VmTemplateCommand hierarchy ...................................................................... core: Refactoring VmTemplateCommand hierarchy * Created VmTemplateManagementCommand as common ancestor of all add/update/remove VM Template commands. Moved all methods specific to these commands from VmTemplateCommand to VmTemplateManagementCommand. * Created VmTemplateManagementParameters as common ancestor of all add/update/remove VM Template command parameters. Moved all fields specific to these commands from VmTemplateParametersBase to VmTemplateManagementParameters. * Renamed VmTemplateParametersBase to VmTemplateParameters. * Deleted quoteId and cpuProfileId fields from VmTemplateParameters, because they are not used anywhere. * Moved isVmPriorityValueLegal() method to VmHandler, because it is used outside VmTemplateCommand hierarchy. * Moved isDomainLegal() method to UpdateVmTemplateCommand, because it is specific to this command. * Fixed doc comments and typos in method names. Change-Id: I4f0a511f3d15100f6deeae4509959861db6d966e Signed-off-by: Shmuel Melamud <smelamud@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateManagementCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateInterfaceParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmTemplateInterfaceParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateImportExportParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateManagementParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateParametersBase.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/instancetypes/InstanceTypeListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java 23 files changed, 346 insertions(+), 329 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/66113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f0a511f3d15100f6deeae4509959861db6d966e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>