Shahar Havivi has submitted this change and it was merged. Change subject: core: Extract hardcoded strings to constants ...................................................................... core: Extract hardcoded strings to constants This patch pulls hardcoded strings in VmConditionFieldAutoCompleter to constants. They are used in follow up frontend patch (sorting columns in VM main tab in webadmin application). Change-Id: I7d2fb964cc0c5520e37cd190e88f09d4218868d2 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com&gt; Bug-Url: https://bugzilla.redhat.com/1103715 --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java 1 file changed, 112 insertions(+), 86 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Frank Kobzik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d2fb964cc0c5520e37cd190e88f09d4218868d2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com&gt; Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com&gt; Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt; Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com&gt; Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt; Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server