Michael Pasternak has submitted this change and it was merged. Change subject: cli: make sure history /connect entry removed even in case of internal failure ...................................................................... cli: make sure history /connect entry removed even in case of internal failure unsuccessful /connect attempt won't be logged anyway (as history collector not enabled yet), this patch prepares infrastructure for future use where internal failures can occur before self.__remove_history_entry() get called. Change-Id: I7bcd15cf93e1a46eb07eacfb29e5f0751e021ace Signed-off-by: Michael Pasternak <mpastern@redhat.com> --- M src/ovirtcli/command/connect.py 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bcd15cf93e1a46eb07eacfb29e5f0751e021ace Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern@redhat.com> Gerrit-Reviewer: Ori Liel <oliel@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com>