Omer Frenkel has submitted this change and it was merged. Change subject: core: extract parameters initialization to seperate method ...................................................................... core: extract parameters initialization to seperate method Extract long blocks of code that initialize command parameters from MoveOrCopyTemplateCommand#moveOrCopyAllImageGroups and AddVmFromTemplateCommand#addVmImages methods to separate methods in order to make the code more concise and readable Change-Id: I7328e84274fd9ba9f109608600da66c6308ec0b9 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java 2 files changed, 32 insertions(+), 26 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7328e84274fd9ba9f109608600da66c6308ec0b9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server