Change in ovirt-engine[master]: core: Remove useless initialization of macPool in AddVmCommand

From Tal Nisan <tnisan@redhat.com>:
Tal Nisan has submitted this change and it was merged. Change subject: core: Remove useless initialization of macPool in AddVmCommand ...................................................................... core: Remove useless initialization of macPool in AddVmCommand The macPool variable was initialized at the beginning of the validate method for no apparent reason also this initialization is costly since it requires locking. The getMacPool() method is a lazy getter and should be used instead and will be initialized only if needed Change-Id: I8ff8c38a19cab2d11af3a738f2845e1c6aa3564a Signed-off-by: Tal Nisan <tnisan@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65993 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ff8c38a19cab2d11af3a738f2845e1c6aa3564a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Ala Hino <ahino@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review