Oved Ourfali has submitted this change and it was merged. Change subject: core: drop ConnectSingleAsyncOperation ...................................................................... core: drop ConnectSingleAsyncOperation This patch drops the ConnectSingleAsyncOperation and it's factory with the simple use of callables. The ConnectSingleAsyncOperation is more complicated, harder to maintain and limited than the simple use of callables (for example, results can't be returned from it at the moment). There's currently no need for that infrastructure, we can execute the needed operations from a helper or a helper method. Change-Id: I825d80da10ef3d22de7cd68a68d854374e6c136c Bug-Url: https://bugzilla.redhat.com/1115845 Signed-off-by: Liron Aravot <laravot(a)redhat.com&gt; --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperation.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java 4 files changed, 28 insertions(+), 45 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I825d80da10ef3d22de7cd68a68d854374e6c136c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt; Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server