Alona Kaplan has submitted this change and it was merged. Change subject: core: update network attachments accordingly when attaching/detaching network to/from cluster ...................................................................... core: update network attachments accordingly when attaching/detaching network to/from cluster • when detaching network from cluster, network attachment has to be removed as well. Otherwise network attachment will reference network which does not exist on cluster, which in turn end up in NPEs. • when attaching network to cluster, network attachment has to be created for each unamanaged network of given name on each host, otherwise code will not fail, but user will remain with unmanaged networks. Change-Id: Id960edcb4cf1c00e96ded93c2ed0696b16c10c73 Bug-Url: https://bugzilla.redhat.com/1247037 Signed-off-by: Martin Mucha <mmucha@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToClusterInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkAttachmentDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkAttachmentDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkAttachmentDaoTest.java M packaging/dbscripts/network_sp.sql 6 files changed, 83 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44083 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id960edcb4cf1c00e96ded93c2ed0696b16c10c73 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: automation@ovirt.org