Maor Lipchuk has submitted this change and it was merged. Change subject: core: Introduce allow snapshot attribute for disk ...................................................................... core: Introduce allow snapshot attribute for disk Adding field of allow snapshot to disk entity. For now this field will be used for shared disk and direct lun. In the future it should indicate which disk will be snapshot in the VM or not. Disk which will have false allow snapshot attribute will be static in the VM, which means there will be no representation in time of the disk. When VM will be previewed and commited or rollbacked after that, the disk will still be part of the VM. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Change-Id: I99caa62cd6f966fe6867fb2f42bcf5019fa65ee5 --- M backend/manager/dbscripts/base_disks_sp.sql M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_01_1080_add_allow_snapshot.sql M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmByVmIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LunDisk.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractDiskRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 12 files changed, 72 insertions(+), 15 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99caa62cd6f966fe6867fb2f42bcf5019fa65ee5 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com&gt; Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com&gt;