Allon Mureinik has submitted this change and it was merged. Change subject: core: String equality checks ...................................................................... core: String equality checks Use equality instead of identity (==, !=) when comparing strings. While the JVM usually produces the same literal from the pool this is not a behavior that should be relied on. Instead, logical equality should be checked. A checkstyle check was added to ensure such errors are not repeated. Change-Id: I987ca985240f7783f677b785f058ed16edafe5f4 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M build-tools-root/checkstyles/src/main/resources/checkstyle.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/quota/QuotaPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 3 files changed, 4 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/51263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I987ca985240f7783f677b785f058ed16edafe5f4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>