Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Split link helper ...................................................................... restapi: Split link helper Currently the "LinkHelper" class contains method that work with links that don't depend on the current request and also with links that do depend. The methods that work with links that dpened on the current request will in the future be changed to use the "Current" class instead of the "UriInfo" class, and to do so the class needs to be part of the "jaxrs" module. To enable that future change this patch splits the "LinkHelper" class into two: "LinkHelper" and "LinkCreator". The first will contain the methods that work with the current request, and the second will contain the methods that work with links that don't work with the current request. Change-Id: I61c48887e8ba4bf5fd23905d51e24d95dce8f5ca Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- A backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/LinkCreatorTest.java M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/LinkHelperTest.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkCreator.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAsyncStatusResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java 9 files changed, 203 insertions(+), 159 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/52702 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61c48887e8ba4bf5fd23905d51e24d95dce8f5ca Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Ori Liel <oliel@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>