Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: DB connections improvement at notifier ...................................................................... tools: DB connections improvement at notifier A performance issue (and maybe not the only one) exists at NotificationService: There is a loop over the result-set representing the event subscrirbers. As long as the result-set object is active the connection is held. in each iteration there is an attempt to send mail - this operation may take time. The patch seperates the DB extraction of subscribers from the logic that is done with each one of them. This patch also adds a close to a connection at the method updateAuditLogEventProcessed Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=882847 Change-Id: I54fb540ee52255f017933b000b9b509c2e056122 Signed-off-by: Yair Zaslasky <yzaslavs@redhat.com> --- M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java 1 file changed, 34 insertions(+), 25 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54fb540ee52255f017933b000b9b509c2e056122 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Ravi Nori <rnori@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>