Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Generify & IoC provider proxy factory ...................................................................... engine: Generify & IoC provider proxy factory To support multiple provider & provider proxy types, this factory should be generic and return the correct type. Also turned the factory into a singleton which returns an instance that can be used for DI, so that interacting classes don't have to rely on a static relationship with the factory class. Change-Id: I79d80c28921e417e9cfbb35bb621bbdb751c667a Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxyFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/TestProviderConnectivityCommand.java 2 files changed, 18 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79d80c28921e417e9cfbb35bb621bbdb751c667a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com&gt; Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com&gt; Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt; Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt; Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt;