Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "Integer.compare" in "VdsCpuUsageComparator" ...................................................................... core: Use "Integer.compare" in "VdsCpuUsageComparator" This is needed in order to avoid the following findbugs error: Boxing a primitive to compare A boxed primitive is created just to call compareTo method. It's more efficient to use static compare method (for double and float since Java 1.4, for other primitive types since Java 1.7) which works on primitives directly. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_COMPARE Change-Id: I9b1f5995785399f3e5352949ab9c27e648460a5e Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUsageComparator.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46566 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b1f5995785399f3e5352949ab9c27e648460a5e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Martin Sivák <msivak@redhat.com> Gerrit-Reviewer: automation@ovirt.org