Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Bonding modes 0, 5 and 6 should be avoided for VM networks ...................................................................... webadmin: Bonding modes 0, 5 and 6 should be avoided for VM networks Bonds with bonding modes 0, 5 and 6 should be prohibited from having vm networks. This patch modifies the setup networks dialog not to allow to attach a vm network to a bond with such bonding options, and also prohibits to change the bonding options to such if a vm network is attached. Change-Id: I9bc5f0da68ce8cc55bda1c7aaf8568e7bbd9bda0 Bug-Url: https://bugzilla.redhat.com/1094842 Signed-off-by: Marcin Mirecki <mmirecki@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksAddBondModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksBondModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksEditBondModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksJoinBondsModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 10 files changed, 87 insertions(+), 16 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bc5f0da68ce8cc55bda1c7aaf8568e7bbd9bda0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marcin Mirecki <mmirecki@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com> Gerrit-Reviewer: automation@ovirt.org