Oved Ourfali has submitted this change and it was merged. Change subject: host-deploy: attemptConnection() should not throw exceptions ...................................................................... host-deploy: attemptConnection() should not throw exceptions The expected return value of ProtocolDetector.attemptConnection() is a boolean on which the installation process relies. The installation process does not expect this method to throw an exception if the attempt to connect to the host has failed. Change-Id: I3f581e973b01d33458e5f6d37830704f3e508b6a Bug-Url: https://bugzilla.redhat.com/1299232 Signed-off-by: Moti Asayag <masayag@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52394 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f581e973b01d33458e5f6d37830704f3e508b6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>