Barak Azulay has submitted this change and it was merged. Change subject: Replaced String check with string conversion ...................................................................... Replaced String check with string conversion Currently the string_check is destroying the data when the system is not able to convert them properly. This is now fixed by allowing unicode strings as they are and an attempt of decoding input (non-unicode) strings based on the prefered locale encoding. If this will fail, the replacement of unknown characters are applied. In any case an unicode string is created. If the string is not convertible, the return value will be "????" as a replacement. This however is the last resort, to allow at least some level of data to go through. (e.g. when the application list contains one invalid data string currently it would cause the whole list NOT to be sent. Now it will be sent) Please also note that this commit will fix the failing unit tests. Change-Id: Ie277069cbfa39f9735a2b85b9e9da9c3fcfe5938 Signed-off-by: Vinzenz Feenstra <vfeenstr@redhat.com> --- M ovirt-guest-agent/VirtIoChannel.py 1 file changed, 8 insertions(+), 9 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve Barak Azulay: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19053 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie277069cbfa39f9735a2b85b9e9da9c3fcfe5938 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr@redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr@redhat.com>