Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: WelcomeServletTest mocking ...................................................................... webadmin: WelcomeServletTest mocking Mock the WelcomeSelet instead boiler-plate implementing it, which is hard to read and maintain. Change-Id: Id949a01a933c14e74dcf36e4fbd741db347eb5da Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M backend/manager/modules/welcome/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java 1 file changed, 4 insertions(+), 30 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/73631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id949a01a933c14e74dcf36e4fbd741db347eb5da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com&gt; Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com&gt; Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;