Arik Hadas has submitted this change and it was merged. Change subject: core: simplify persistence of vm-init ...................................................................... core: simplify persistence of vm-init Pass just the VmInit instead of its wrapping VmBase instance. The VmInit class should contain the id of the VM, we just ensure it is properly initialized in VmBase#getVmInit. This change is aligned with the best-practice of passing only the required information for the execution of a method. Change-Id: I4919b50ffa87f34dab9a28ad0870e3ce0602081e Signed-off-by: Arik Hadas <ahadas(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 6 files changed, 15 insertions(+), 13 deletions(-) Approvals: Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4919b50ffa87f34dab9a28ad0870e3ce0602081e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;