Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: don't allow removal of inherited perms via rest ...................................................................... engine: don't allow removal of inherited perms via rest Previously it was possible to remove inherited permissions from user/group via rest api call. Now we do check at backend if user is trying to remove inherited permissions from user/group and if yes we do not allow it. Change-Id: Ica8610e4cf613629c0fbc0a8d7414598a8bbd899 Bug-Url: https://bugzilla.redhat.com/1340932 Signed-off-by: Ondra Machacek <omachace@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PermissionsOperationsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResourceTest.java 7 files changed, 33 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Ondra Machacek: Verified Martin Peřina: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58355 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica8610e4cf613629c0fbc0a8d7414598a8bbd899 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ondra Machacek <omachace@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>