Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: [SetupNetworks] detach unmanaged net causes NPE (#848354)
......................................................................
webadmin: [SetupNetworks] detach unmanaged net causes NPE (#848354)
https://bugzilla.redhat.com/848354
Fixing bug 848354- caused NPE when detching unmanaged network.
The fix was- that when detaching unsync network the is_vm, vlan-id,
and mtu parameters should be set to the values defined in the dc
logical network level. The problem is that unmanaged network also
marked as unsync. And on detach it just have to be deleted, no need
to set the dc parameters.
Change-Id: Ic63105d7e352845d795fd99f4099c812723bca6e
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/7669
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic63105d7e352845d795fd99f4099c812723bca6e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>