Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Vm dialog- bugs with nic naming ...................................................................... webadmin: Vm dialog- bugs with nic naming New nic name should be- nic + the highest existing nic num + 1. Since remove from the vnics list didn't work the list contained the old nics and the naming logic didn't work. To fix the issue 'vnics' type was changed from Set to List. VmNetworkInterface is mutable and changing its fields affects hashcode and equals. The javadoc for Set says: Note: Great care must be exercised if mutable objects are used as set elements. The behavior of a set is not specified if the value of an object is changed in a manner that affects equals comparisons while the object is an element in the set. Change-Id: Ib8594a29ba9c8ed32e4a0d4f8df78212dfc9f40f Bug-Url: https://bugzilla.redhat.com/1049789 Signed-off-by: Alona Kaplan <alkaplan@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8594a29ba9c8ed32e4a0d4f8df78212dfc9f40f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server